fix benchmarks #205
Merged
fix benchmarks #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
=======================================
Coverage 97.23% 97.23%
=======================================
Files 114 114
Lines 6584 6584
=======================================
Hits 6402 6402
Misses 182 182 |
|
Thanks a bunch @miguelraz! I guess you can't make a clean up omelet without breaking some benchmark eggs 🤷 |
gdalle
approved these changes
Feb 9, 2023
|
Oh neat! No problem. I needed to benchmark some stuff for the eventual lil' blogpost I wanted to write about Boolean graphs I wanted to write and I got yak-shaved into fixing the benchmarks. Keep poking me until I write that package... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a previous code cleanup massive PR seems to have introduced this macro change that broke benchmarking.
this should work now.