Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add planarity test and PMFG #208

Open
wants to merge 37 commits into
base: master
Choose a base branch
from

Conversation

josephcbradley
Copy link

@josephcbradley josephcbradley commented Jan 2, 2023

This is an implementation of a planarity test and an algorithm to construct a planar maximally filtered graph, as mentioned in #153.

It is functioning and there are some basic tests for the planarity algorithm, but there are quite a few todos:

  • add tests for the PMFG algorithm
  • Speed up the PMFG algorithm (currently reallocating lots of structures that don't need to be)
  • implement traits for the PMFG algorithm (I could not get this to work for the life of me, would appreciate a pointer from someone more familiar with the syntax!)

etc. etc.

This is my first pull request so feedback appreciated!

@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Merging #208 (e2b4862) into master (53cb581) will increase coverage by 0.21%.
The diff coverage is 98.19%.

❗ Current head e2b4862 differs from pull request most recent head 9ea7ec8. Consider uploading reports for the commit 9ea7ec8 to get more accurate results

@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
+ Coverage   97.23%   97.45%   +0.21%     
==========================================
  Files         114      115       +1     
  Lines        6585     6752     +167     
==========================================
+ Hits         6403     6580     +177     
+ Misses        182      172      -10     

@josephcbradley josephcbradley changed the title Josephcbradley/issue153 Add planarity test and PMFG Jan 6, 2023
@simonschoelly
Copy link
Contributor

Hey, thanks for this contribution, I think planarity is indeed something we could use.

It might take a bit longer to completely review this PR, as these planarity algorithms are not known that much, so at least I need to get familiar with them again.

src/Graphs.jl Outdated Show resolved Hide resolved
src/planarity.jl Outdated Show resolved Hide resolved
@josephcbradley
Copy link
Author

@simonschoelly I think that's everything for now.

I've added the docs for planarity and for the PMFG to the spanning trees page, as that's where it felt most relevant.

@gdalle gdalle added the enhancement New feature or request label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants