Fix sanity checks for Eulerian trail #397
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sanity check for a graph having an Eulerian trail was incorrect: for a connected simple graph to have an Eulerian trail there must be exactly two odd degree vertices, but the existing code checks for exactly two even degree vertices. The current test happened to test on a 4-vertex graph with two even and two odd degree vertices, so the test passed.
I just flipped the check and added the relevant tests.