adjustments to two tests #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous CIDs being matched in the test do not exist in the PubChem database. Consequently, when testing on the PubChem website directly instead of using the BrokenRecord files, the tests were failing. With this change tests do not fail anymore, as I replaced the erroneous CID with one that exists in PubChem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous CID (153064026) being matched in the test do not exist in the PubChem database. Consequently, when testing on the PubChem website directly instead of using the BrokenRecord files, these tests were failing. With this change tests do not fail anymore, as I replaced the erroneous CID with one that exists in PubChem.
Note: when testing the package on the PubChem database directly some tests still seem to be broken. But I noticed that upgrading the version of HTTP.jl in the Project.toml corrects this, and the tests run smoothly. I'll soon PR an update to the Project.toml