Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize & improve functionality #2

Merged
merged 4 commits into from
Nov 11, 2020
Merged

Generalize & improve functionality #2

merged 4 commits into from
Nov 11, 2020

Conversation

timholy
Copy link
Member

@timholy timholy commented Nov 11, 2020

Adds:

  • SMILES support for get_cid
  • xrefs support for get_for_cids
  • simple fallbacks and more diversity in tests

Adds:
- SMILES support for `get_cid`
- `xrefs` support for `get_for_cids`
- simple fallbacks and more diversity in tests
@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #2 (c3abe89) into master (1fbfb66) will increase coverage by 1.63%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
+ Coverage   87.50%   89.13%   +1.63%     
==========================================
  Files           3        3              
  Lines          40       46       +6     
==========================================
+ Hits           35       41       +6     
  Misses          5        5              
Impacted Files Coverage Δ
src/utils.jl 89.47% <ø> (ø)
src/query.jl 88.46% <100.00%> (+3.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fbfb66...c3abe89. Read the comment docs.

@timholy timholy merged commit 6bf9a32 into master Nov 11, 2020
@timholy timholy deleted the teh/enhance branch November 11, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant