Merge pull request #5 from JuliaIO/tweaks_for_videoio

Expanding collect to other methods and testing
JuliaIO · Jul 12, 2019 · dd5bd66 · dd5bd66 · IanButterworth · Jul 12, 2019
2 parents bfe09ff + 6068ccc
commit dd5bd66
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/src/FFMPEG.jl b/src/FFMPEG.jl
@@ -91,13 +91,8 @@ built with clang version 6.0.1 (tags/RELEASE_601/final)
 [...]
 ```
 """
-function exe(args::AbstractString...; command = FFMPEG.ffmpeg)
+exe(args::AbstractString...; command = FFMPEG.ffmpeg, collect = false) = exe(Cmd([command, args...]), command=command, collect=collect)
 
-    withenv(execenv) do
-        Base.run(Cmd([command, args...]))
-    end
-
-end
 
 """
     collectexecoutput(exec::Cmd) -> Array of output lines

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -13,6 +13,7 @@ end
     @show FFMPEG.versioninfo()
     @test text_execute(() -> FFMPEG.exe("-version"))
     @test text_execute(() -> FFMPEG.exe(`-version`))
+    @test text_execute(() -> FFMPEG.exe(`-version`, collect=true))
     @test text_execute(() -> FFMPEG.ffmpeg_exe(`-version`))
     @test text_execute(() -> FFMPEG.ffprobe_exe(`-version`))
     @test text_execute(() -> ffmpeg`-version`)