Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new binaries from Yggdrasil #18

Merged
merged 4 commits into from
Nov 27, 2019
Merged

Use new binaries from Yggdrasil #18

merged 4 commits into from
Nov 27, 2019

Conversation

giordano
Copy link
Member

This should finally solve several problems for Windows users. I'd tentatively say: fix #12. I think we should also have a new release after this.

Thank you so much to @staticfloat for patient help in debugging a silly error on my side.

@codecov
Copy link

codecov bot commented Nov 26, 2019

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #18   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          39     39           
=====================================
  Hits           39     39
Impacted Files Coverage Δ
src/FFMPEG.jl 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6cca77...81fc1dc. Read the comment docs.

@SimonDanisch
Copy link
Member

Noice!!! :)

@giordano
Copy link
Member Author

Good to merge? 🙂

@SimonDanisch SimonDanisch merged commit d14f30c into JuliaIO:master Nov 27, 2019
@giordano giordano deleted the yggdrasil branch November 27, 2019 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERROR: LoadError: UndefVarError: ffmpeg not defined
2 participants