Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to FFMPEG_jll 4.3.1 with optional nvidia hardware accelerated encoding #32

Merged
merged 7 commits into from
Aug 4, 2020

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Aug 3, 2020

Waiting on JuliaPackaging/Yggdrasil#1384
Will need re-running once that releases

@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #32 into master will increase coverage by 2.56%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #32      +/-   ##
===========================================
+ Coverage   97.43%   100.00%   +2.56%     
===========================================
  Files           1         1              
  Lines          39        38       -1     
===========================================
  Hits           38        38              
+ Misses          1         0       -1     
Impacted Files Coverage Δ
src/FFMPEG.jl 100.00% <ø> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d72621f...35c7c1e. Read the comment docs.

ffmpeg 4.3.1 with optional nvidia hardware acceleration enabled
@IanButterworth IanButterworth marked this pull request as ready for review August 3, 2020 17:47
@IanButterworth
Copy link
Member Author

Tests are passing here. FreeBSD appears to be an unrelated CI julia issue (any idea @ararslan ?)

I've tested downstream VideoIO on a MacOS non-gpu, and ubuntu gpu system, and tests pass.
The VideoIO tests don't yet cover the h264_nvenc codec though, so that's experimental, but codec information does get printed via FFMPEG.exe(`-h encoder=h264_nvenc`).

I believe this should be a bump to 0.4.0 given it upgrades ffmpeg from 4.1 to 4.3

@SimonDanisch what do you think? I want to be careful about messing up downstream plotting packages, which I already did twice today already..

@IanButterworth
Copy link
Member Author

The minor version bump should protect downstream packages here, so I'll merge and release

@IanButterworth IanButterworth merged commit ac20d2d into master Aug 4, 2020
@IanButterworth IanButterworth deleted the ib/ffmpeg4_3_1 branch August 4, 2020 02:55
@ararslan
Copy link
Member

ararslan commented Aug 4, 2020

Ah yeah, we should switch the FreeBSD CI here from Cirrus to Travis. Cirrus FreeBSD images inexplicably stopped working a while ago, luckily just in time for Travis to add support for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants