Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use thread-safe call to ffmpeg in Julia v1.6 #47

Merged
merged 1 commit into from
Aug 13, 2021
Merged

Use thread-safe call to ffmpeg in Julia v1.6 #47

merged 1 commit into from
Aug 13, 2021

Conversation

giordano
Copy link
Member

Interestingly enough, this makes exe a bit more type-stable (a union type
instead of Any):

before:

julia> @code_warntype FFMPEG.exe(`-version`);
Variables
  #self#::Core.Const(FFMPEG.exe)
  arg::Cmd

Body::Any
1%1 = FFMPEG.:(var"#exe#5")(FFMPEG.ffmpeg, false, #self#, arg)::Any
└──      return %1

after:

julia> @code_warntype FFMPEG.exe(`-version`);
Variables
  #self#::Core.Const(FFMPEG.exe)
  arg::Cmd

Body::Union{Base.Process, Vector{String}}
1%1 = FFMPEG.:(var"#exe#10")(FFMPEG.ffmpeg, false, #self#, arg)::Union{Base.Process, Vector{String}}
└──      return %1

@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #47 (cac1f04) into master (a819cde) will decrease coverage by 2.32%.
The diff coverage is 66.66%.

❗ Current head cac1f04 differs from pull request most recent head bb4eee3. Consider uploading reports for the commit bb4eee3 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##            master      #47      +/-   ##
===========================================
- Coverage   100.00%   97.67%   -2.33%     
===========================================
  Files            1        1              
  Lines           44       43       -1     
===========================================
- Hits            44       42       -2     
- Misses           0        1       +1     
Impacted Files Coverage Δ
src/FFMPEG.jl 97.67% <66.66%> (-2.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a819cde...bb4eee3. Read the comment docs.

@giordano giordano merged commit 1b04ffc into JuliaIO:master Aug 13, 2021
@giordano giordano deleted the mg/safe branch August 13, 2021 15:07
@giordano giordano linked an issue Sep 23, 2024 that may be closed by this pull request
@giordano giordano mentioned this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Depwarn caused by non-deprecated entry point exe
2 participants