Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expanding collect to other methods and testing #5

Merged
merged 2 commits into from
Jul 12, 2019
Merged

Expanding collect to other methods and testing #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
857cdb3
expanding collect to other methods and testing
IanButterworth Jul 12, 2019
6068ccc
function arg error
IanButterworth Jul 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/FFMPEG.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,13 +91,8 @@ built with clang version 6.0.1 (tags/RELEASE_601/final)
[...]
```
"""
function exe(args::AbstractString...; command = FFMPEG.ffmpeg)
exe(args::AbstractString...; command = FFMPEG.ffmpeg, collect = false) = exe(Cmd([command, args...]), command=command, collect=collect)

withenv(execenv) do
Base.run(Cmd([command, args...]))
end

end

"""
collectexecoutput(exec::Cmd) -> Array of output lines
Expand Down
1 change: 1 addition & 0 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ end
@show FFMPEG.versioninfo()
@test text_execute(() -> FFMPEG.exe("-version"))
@test text_execute(() -> FFMPEG.exe(`-version`))
@test text_execute(() -> FFMPEG.exe(`-version`, collect=true))
@test text_execute(() -> FFMPEG.ffmpeg_exe(`-version`))
@test text_execute(() -> FFMPEG.ffprobe_exe(`-version`))
@test text_execute(() -> ffmpeg`-version`)
Expand Down