Fix variable length strings as attributes (#1130)

Fixes #1129
JuliaIO · Dec 23, 2023 · 91ef284 · 91ef284
1 parent 4568054
commit 91ef284
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/src/attributes.jl b/src/attributes.jl
@@ -201,8 +201,13 @@ end
 function write_attribute(attr::Attribute, memtype::Datatype, str::AbstractString)
     strbuf = Base.cconvert(Cstring, str)
     GC.@preserve strbuf begin
-        buf = Base.unsafe_convert(Ptr{UInt8}, strbuf)
-        write_attribute(attr, memtype, buf)
+        if API.h5t_is_variable_str(memtype)
+            ptr = Base.unsafe_convert(Cstring, strbuf)
+            write_attribute(attr, memtype, Ref(ptr))
+        else
+            ptr = Base.unsafe_convert(Ptr{UInt8}, strbuf)
+            write_attribute(attr, memtype, ptr)
+        end
     end
 end
 function write_attribute(

diff --git a/test/attributes.jl b/test/attributes.jl
@@ -69,3 +69,13 @@ end
         close(f)
     end
 end
+
+@testset "variable length strings" begin
+    filename = tempname()
+    h5open(filename, "w") do f
+        # https://github.com/JuliaIO/HDF5.jl/issues/1129
+        attr = create_attribute(f, "attr-name", datatype(String), dataspace(String))
+        write_attribute(attr, datatype(String), "attr-value")
+        @test attrs(f)["attr-name"] == "attr-value"
+    end
+end