bump ImageMagick_jll, add test for #206 #215
Conversation
|
Ah, I see, it's not tagged yet, Yggdrasil is still busy: https://buildkite.com/julialang/yggdrasil/builds/607 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #215 +/- ##
==========================================
- Coverage 75.73% 75.51% -0.23%
==========================================
Files 3 3
Lines 441 441
==========================================
- Hits 334 333 -1
- Misses 107 108 +1 ☔ View full report in Codecov by Sentry. |
should also fix JuliaIO#158
simeonschaub
force-pushed
the
sds/bump_jll
branch
from
1d2580e to
c2cf4f3
Compare
There was a problem hiding this comment.
Thanks for tracking down this! I've tested it locally that it fixes #206 for macOS.
|
Unfortunately with the latest Ghostscript changes, loading a PDF now segfaults even if you have commandline |
|
Yes, it'd be good not to have totally unusable versions around. |
|
Ok, everything should be ready to go now |
|
Wait, may have spoken too soon... https://github.com/JuliaIO/ImageMagick.jl/actions/runs/4098160637/jobs/7067061198 |
|
Do I need to be on a Windows system for that? |
|
Yes. But you can use https://github.com/mxschmitt/action-tmate to get one |
|
Well, there isn't much to do: % file libgs-9.dll
libgs-9.dll: broken symbolic link to libgs-9-55.dll |
|
So is the issue that we forgot to copy the original file? |
|
Is there anything still holding this up? I would like to help if possible. |
|
I'm merging this in order to get things working on M1. Since all tests are passing here, I feel comfortable doing so - but should be easy enough to revert or update further. |
|
Fixes #226 |
should also fix #158