Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom subtypes function to avoid deprecation warnings #236

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

dgleich
Copy link
Member

@dgleich dgleich commented Oct 13, 2024

Fixes #235

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.73%. Comparing base (0bd5d85) to head (43a7f98).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/libmagickwand.jl 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
+ Coverage   68.43%   69.73%   +1.30%     
==========================================
  Files           3        3              
  Lines         434      456      +22     
==========================================
+ Hits          297      318      +21     
- Misses        137      138       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ViralBShah
Copy link
Contributor

@timholy Would be good if you can review.

@ViralBShah ViralBShah merged commit 26747c6 into JuliaIO:master Oct 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImageCore warning needs fixing (by using XRGB and RGBX)
2 participants