Support non-1 indices #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timholy
commented
Apr 17, 2017
src/ImageMagick.jl
Outdated
| else | ||
| const collect1 = collect | ||
| end | ||
|
|
There was a problem hiding this comment.
Probably worth CCing @tkelman here. I don't think JuliaLang/julia#21257 can safely be backported to julia-0.5. I guess the question is whether Compat should define collect1?
This was referenced Apr 18, 2017
|
Single test failure is a little weird, but since this has been changing recently (JuliaLang/julia#21369) I think I won't worry about it just yet. (In any event, it's quite a corner case...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar changes might be desired in QuartzImageIO, CC @rsrock.
Tests expected to fail on 0.6 due to JuliaLang/julia#21369, but if you run the tests a second time in the same session, it passes locally on 0.6.