Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #327 DataType has no field ninitialized #331

Merged
merged 5 commits into from
Jun 27, 2021

Conversation

jw3126
Copy link
Contributor

@jw3126 jw3126 commented Jun 25, 2021

fix #327

@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #331 (10874f1) into master (6db2287) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #331      +/-   ##
==========================================
+ Coverage   89.87%   89.88%   +0.01%     
==========================================
  Files          27       27              
  Lines        2715     2720       +5     
==========================================
+ Hits         2440     2445       +5     
  Misses        275      275              
Impacted Files Coverage Δ
src/backwards_compatibility.jl 75.00% <100.00%> (+8.33%) ⬆️
src/data/reconstructing_datatypes.jl 74.00% <100.00%> (ø)
src/data/writing_datatypes.jl 96.58% <100.00%> (ø)
src/dataio.jl 98.46% <0.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6db2287...10874f1. Read the comment docs.

@JonasIsensee
Copy link
Collaborator

Hi @jw3126 ,
thanks a lot for taking care of this!

@JonasIsensee JonasIsensee merged commit a9c62a6 into JuliaIO:master Jun 27, 2021
@jw3126
Copy link
Contributor Author

jw3126 commented Jun 27, 2021

@JonasIsensee thanks a lot for maintaining this essential package!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error DataType has no field ninitialized when saving Tuple
2 participants