Fix inference problems in read_header (#78)

This eliminates 198 invalidations from `using CategoricalArrays`.
JuliaIO · Nov 2, 2020 · ba88678 · ba88678
1 parent 853aa7f
commit ba88678
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/src/extract.jl b/src/extract.jl
@@ -362,12 +362,14 @@ function read_header(
     metadata = copy(globals)
     while true
         if hdr.type in (:g, :x) # POSIX extended headers
-            read_extended_metadata(io, hdr.size, buf=buf, tee=tee) do key, val
-                if key in ("size", "path", "linkpath")
-                    if hdr.type == :g
-                        globals[key] = val
+            let hdr=hdr         #15276
+                read_extended_metadata(io, hdr.size, buf=buf, tee=tee) do key, val
+                    if key in ("size", "path", "linkpath")
+                        if hdr.type == :g
+                            globals[key] = val
+                        end
+                        metadata[key] = val
                     end
-                    metadata[key] = val
                 end
             end
         elseif hdr.path == "././@LongLink" && hdr.type in (:L, :K)