extract: normalize tarball modes (like git) #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
=======================================
Coverage 96.36% 96.37%
=======================================
Files 4 4
Lines 633 634 +1
=======================================
+ Hits 610 611 +1
Misses 23 23
Continue to review full report at Codecov.
|
StefanKarpinski
force-pushed
the
sk/normalize-modes
branch
3 times, most recently
from
2dc5a54 to
39080f5
Compare
Also update docs to reflect that we now normalize permissions on tarball extraction as well as creation. This also adds more detail on permissions in the relevant section of the README.
StefanKarpinski
force-pushed
the
sk/normalize-modes
branch
from
39080f5 to
010f1a8
Compare
|
Updated the docs so this is now ready for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would require a minor version bump since it changes the way extraction handles permissions: this changes it to ignore the exact permissions in the tarball and only pay attention to whether each file is user-executable and then behave as if the permissions where the git-normlized ones of
0o644and0o755. Unlike the other permission changes, which were bugfixes to deal withfilemodebeing unreliable on some platforms, this is a policy change. It's currently a draft since I need to change the docs back to an older version where they claimed this was the behavior even though it actually wasn't at the time.