Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert fill values correctly from negative to unsigned integers #165

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

asinghvi17
Copy link
Member

Positive integers are unaffected by this change anyway.

Needs tests, probably.

Positive integers are unaffected by this change anyway.
@asinghvi17 asinghvi17 closed this Oct 9, 2024
@asinghvi17 asinghvi17 reopened this Oct 9, 2024
Copy link
Collaborator

@meggart meggart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, how can this be intended behavior, to me it rather sounds like the files that need this are broken. Is there a publicly available dataset that has this behavior or can you share a .zarray file where this comes up? Just out of curiosity...

@asinghvi17
Copy link
Member Author

I believe I got that from https://fsspec.github.io/kerchunk/cases.html#mur-sst, the original NetCDF files have this attribute too.

@coveralls
Copy link

coveralls commented Dec 6, 2024

Pull Request Test Coverage Report for Build 12200254201

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.148%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/metadata.jl 0 1 0.0%
Totals Coverage Status
Change from base Build 12200200130: 0.0%
Covered Lines: 908
Relevant Lines: 1054

💛 - Coveralls

@lazarusA
Copy link

bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants