Prepare v1.82.1 #105
Merged
Prepare v1.82.1 #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
This is a patch release that fixes compat bounds for some dependencies, which were previously allowing newer-than-actually-compatible versions.
JamesWrigley
force-pushed
the
v1.82.1
branch
from
ef65745 to
827274b
Compare
|
(also took the liberty of backporting some docs fixes from @IanButterworth ❤️ ) |
Gnimuc
approved these changes
Nov 11, 2023
|
Thanks for working on this! |
|
NP :) Shall I tag/register the new version? |
|
Feel free to tag a new version if it's ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied from #104:
This is a patch release that fixes compat bounds for some dependencies, which were previously allowing newer-than-actually-compatible versions. See: #100 (comment)
The main change here is to remove the unions from the bounds of ImGuiGLFWBackend.jl, ImGuiOpenGLBackend.jl, and LibCImGui.jl. e.g.
~1.82, 1for LibCImGui.jl means that the allowed versions would be[1.82 - 1.83) union [1 - 2)(if I read the docs correctly), which is not correct since LibCImGui.jl 1.89 is breaking but would still be allowed by that second bound.