Remove vararg support from the generated bindings #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesWrigley
force-pushed
the
no-varargs
branch
from
1c07ef9 to
3833a9f
Compare
|
It does work, without any segfaults. I'll do some more tests and let know |
|
@JamesWrigley I probably should have tested pulling from the repo before. Any versions from that commit on including the branch for this new PR, works just fine on my end. |
|
Oh interesting, I guess those were overwriting the ones from Clang.jl. I'll close this then and tag a new release from master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@thiago4455, can you try this branch and test the demo and any other code you have?