Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No workvec in rotate, foreach in fft_conv #19

Merged
merged 4 commits into from
Oct 15, 2021
Merged

No workvec in rotate, foreach in fft_conv #19

merged 4 commits into from
Oct 15, 2021

Conversation

ZongyuLi-umich
Copy link
Contributor

clean up commits

@ZongyuLi-umich ZongyuLi-umich changed the title no workvec in rotate no workvec in rotate (clean up commits) Oct 13, 2021
@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #19 (d46c881) into main (1bbb40b) will decrease coverage by 0.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
- Coverage   98.83%   98.57%   -0.27%     
==========================================
  Files           8        8              
  Lines         600      630      +30     
==========================================
+ Hits          593      621      +28     
- Misses          7        9       +2     
Impacted Files Coverage Δ
src/fft_convolve.jl 100.00% <100.00%> (ø)
src/plan-psf.jl 100.00% <100.00%> (ø)
src/plan-rotate.jl 100.00% <100.00%> (ø)
src/rotatez.jl 99.02% <100.00%> (-0.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bbb40b...d46c881. Read the comment docs.

@ZongyuLi-umich
Copy link
Contributor Author

ZongyuLi-umich commented Oct 15, 2021

@JeffFessler, I implemeted foreach version of fft_convolve.
Then I rewrote project.jl and backproject.jl with integration of foreach version of imrotate and fft_convolve,
however, I found this is even slower than the :mem version, see the statistics below.
I didn't upload my projection code to github, because I think you might want to change my fft_conv first.

one, fast
337.220 ms
one, mem
793.918 ms
one, foreach
815.774 ms
two, fast
266.518 ms
two, mem
618.369 ms
two, foreach
734.362 ms

@JeffFessler JeffFessler changed the title no workvec in rotate (clean up commits) No workvec in rotate, foreach in fft_conv Oct 15, 2021
@JeffFessler JeffFessler merged commit be3d29d into JuliaImageRecon:main Oct 15, 2021
@JeffFessler
Copy link
Member

Ok, I have merged this for now and I will study the timings over the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants