-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reexport MosaicViews #19
Conversation
Since MosaicView depends on OffsetArrays, I think it's ok to revert #17. With OffsetArray 1.0 released, the main motivation of that is "outdated" now. Edit: just realized that |
Looks fine so far. Do you have a design for a test? |
ReferenceTests are designed for such usages 😄 -- the 22 reference images occupy 88K storage, which is small enough to manage with git. |
The test fails because ColorVectorSpace isn't compatible with ColorTypes v0.10 JuliaGraphics/ColorVectorSpace.jl#128 With a modified Project.toml, it's passed locally. |
@timholy do you think it's appropriate to move this PR to ImageCore? |
Don't merge this until JuliaArrays/MosaicViews.jl#14 get merged, I will rebuild the test when MosaicViews v0.2.0 is registered.TODO:
I bumped a minor version because from now on this package isn't invisible to users anymore. After this, I'll also reexport
ImageShow
fromImages
, and then draft a democard in juliaimages.orgAnother choice is to reexport it in
ImageCore
becauseImageCore
is a collection of different views.MosaicViews
provides a handy toolmosaicview
, which can be seen as an enhanced version ofcat
to make visualization easier. Here're two main usages: