Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Interpolations.jl 0.15 support #168

Merged
merged 4 commits into from
Jan 7, 2024

Conversation

roflmaostc
Copy link
Member

Hi,

as raised in #165 I added support.

Not sure why this failing test was there but it makes sense to remove it?

This update is important for me since it breaks some Zygote with Julia 1.10 ultimately in the dependency chain.

Best,

Felix

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (570ea3f) 90.04% compared to head (87d2840) 90.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #168   +/-   ##
=======================================
  Coverage   90.04%   90.04%           
=======================================
  Files           8        8           
  Lines         221      221           
=======================================
  Hits          199      199           
  Misses         22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roflmaostc
Copy link
Member Author

@johnnychen94 @timholy can we maybe do this rather soon?

I can't update my work to Julia 1.10 because of blocking dependencies which need newer versions for Julia 1.10

@roflmaostc roflmaostc mentioned this pull request Jan 7, 2024
2 tasks
No need to delete this test
@timholy timholy merged commit 3132038 into JuliaImages:master Jan 7, 2024
8 checks passed
@timholy
Copy link
Member

timholy commented Jan 7, 2024

Thanks! New release coming momentarily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants