Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port bwdist code to ImageMorphology #895

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

tlnagy
Copy link
Contributor

@tlnagy tlnagy commented Jun 17, 2020

Fixes #883. This should not be merged until the following are complete:

BLOCKING

@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #895 into master will increase coverage by 1.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #895      +/-   ##
==========================================
+ Coverage   76.38%   77.51%   +1.12%     
==========================================
  Files           9        8       -1     
  Lines         720      667      -53     
==========================================
- Hits          550      517      -33     
+ Misses        170      150      -20     
Impacted Files Coverage Δ
src/Images.jl 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 988cd87...62fe159. Read the comment docs.

@johnnychen94
Copy link
Member

CI fails because pkg server, which is enabled since Julia 1.5, doesn't get synced yet, I'll retrigger the CI later today.

@johnnychen94 johnnychen94 merged commit 5223171 into JuliaImages:master Jun 23, 2020
@johnnychen94
Copy link
Member

johnnychen94 commented Jun 23, 2020

I should have said that this workflow isn't perfect before merging this, e.g., Images v0.22.2 isn't compatible to ImageMorphology v0.2.6 because both export feature_transform/distance_transform, yet they're declared to be compatible 😢.

So I'll need to bump a patch version for this PR very quickly so that users don't hit this incompatibility.

However, we don't have a better choice until we take #898 seriously.

@timholy
Copy link
Member

timholy commented Jun 23, 2020

Yes, I've begun to think that semver + Pkg's version resolver really can't solve the problem fully. Adding a new method to ImageMorphology is not a breaking change in and of itself, only in the context of some other environment. It also runs into problems like JuliaLang/Pkg.jl#1251 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move feature_transform and distance_transform to ImageMorphology?
3 participants