Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use DemoCard v0.2 #114

Merged
merged 1 commit into from
Mar 5, 2020
Merged

use DemoCard v0.2 #114

merged 1 commit into from
Mar 5, 2020

Conversation

johnnychen94
Copy link
Member

@johnnychen94 johnnychen94 commented Mar 5, 2020

A lot of tweaks and bug fixes on DemoCards since v0.1, also the codes related to themes are rewritten with a breaking API, which will be stable by now IMO.

@johnnychen94 johnnychen94 reopened this Mar 5, 2020
@johnnychen94 johnnychen94 merged commit cc4a82d into source Mar 5, 2020
@johnnychen94 johnnychen94 deleted the jc/democard branch March 5, 2020 12:43
@timholy
Copy link
Member

timholy commented Mar 5, 2020

Awesome. I only just noticed that several demos are queued here (again having arrived while I was focusing on the debugger). Should we look into getting them merged, perhaps doing the porting for them? I'd be happy to do much of it as a way of familiarizing myself with DemoCards.

@johnnychen94
Copy link
Member Author

johnnychen94 commented Mar 5, 2020

Codes in #47 and #48 looks trivial to me, but rewrite them with a heavy explanation on the JuliaImages sounds like a good tutorial for new users. We should be proud of the color systems and make good advertisement on it :P

It would be great if you can revisit the documentation and give some keynotes.

I'd be happy to do much of it as a way of familiarizing myself with DemoCards.

As long as you follow the general Documenter and Literate syntaxes, it should be an obvious thing to you 😄

@timholy
Copy link
Member

timholy commented Mar 5, 2020

I decided that out of fairness we should give the authors a chance to update them; if they don't respond soon I'll polish them up myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants