Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added demos: Histogram Equalization and RGB to Grayscale conversion #133

Merged
merged 6 commits into from
Jun 29, 2020
Merged

Added demos: Histogram Equalization and RGB to Grayscale conversion #133

merged 6 commits into from
Jun 29, 2020

Conversation

mgautam98
Copy link
Collaborator

@mgautam98 mgautam98 commented Jun 22, 2020 •
edited
Loading

Added the following demos

  1. histogram (equalization, adaptive equalization, gamma correction)
  2. RGB to grayscale conversion

Since build was failing I couldn't test it.
#47 #48 Are not needed anymore

@johnnychen94
Copy link
Member

The CI looks weird, will check that later today.

@johnnychen94 johnnychen94 reopened this Jun 22, 2020
@johnnychen94
Copy link
Member

johnnychen94 commented Jun 22, 2020 •
edited
Loading

It is an incompatible change introduced by Literate v2.5.0 that accidentally breaks DemoCards, should be fixed in DemoCards v0.2.2 now.

@johnnychen94
Copy link
Member

johnnychen94 commented Jun 24, 2020 •
edited
Loading

@mgautam98 you can now build the docs locally. (Don't forget an ]up to update your local Manifest.toml)

@mgautam98
Copy link
Collaborator Author

@johnnychen94 I tested it on my local machine and fixed some error

johnnychen94
johnnychen94 approved these changes Jun 29, 2020
View reviewed changes
Copy link
Member

@johnnychen94 johnnychen94 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I made some minor usage suggestions, once updated I think it's good to be merged.

Other docs warning seems to be caused by CoordinateTransformations or Rotations, I'll come and fix it in next few days.

docs/examples/color_channels/rgb_grayscale.jl Outdated Show resolved Hide resolved
docs/examples/color_channels/rgb_grayscale.jl Outdated Show resolved Hide resolved
docs/examples/spatial_transformation/histogram_equalization.jl Outdated Show resolved Hide resolved
docs/examples/spatial_transformation/histogram_equalization.jl Outdated Show resolved Hide resolved
@mgautam98
Copy link
Collaborator Author

Thanks for the suggestions I have made the changes

mgautam98 and others added 2 commits June 29, 2020 10:24
@mgautam98 @johnnychen94
Update docs/examples/color_channels/rgb_grayscale.jl
cb2b863 
Co-authored-by: Johnny Chen <johnnychen94@hotmail.com>
@mgautam98 @johnnychen94
Update docs/examples/color_channels/rgb_grayscale.jl
eca8f05 
Co-authored-by: Johnny Chen <johnnychen94@hotmail.com>
@johnnychen94 johnnychen94 merged commit f885ef9 into JuliaImages:source Jun 29, 2020
@johnnychen94
Copy link
Member

Thanks @mgautam98 !

@johnnychen94 johnnychen94 mentioned this pull request Jul 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnychen94 johnnychen94 johnnychen94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgautam98 @johnnychen94