Use compareVersion, which resolves potential future bugs.

JuliaInterop · Aug 31, 2017 · 14234f4 · 14234f4
1 parent 771b0a4
commit 14234f4
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -18,7 +18,8 @@ URL: https://github.com/Non-Contradiction/JuliaCall
 BugReports: https://github.com/Non-Contradiction/JuliaCall/issues
 Encoding: UTF-8
 LazyData: true
-Imports: inline
+Imports: inline,
+    utils
 RoxygenNote: 6.0.1
 SystemRequirements: Julia >= 0.5.0, RCall.jl
 Suggests: testthat
diff --git a/R/aaa.R b/R/aaa.R
@@ -18,3 +18,5 @@ julia_check <- function(){
              warning = function(war){},
              error = function(err) FALSE)
 }
+
+newer <- function(x, y) utils::compareVersion(x, y) >= 0
diff --git a/R/zzz.R b/R/zzz.R
@@ -67,15 +67,15 @@ julia_setup <- function(verbose = TRUE, force = FALSE) {
 
     if (verbose) message(paste0("Julia version ", .julia$VERSION, " found."))
 
-    if (.julia$VERSION < "0.6.0") {
+    if (!newer(.julia$VERSION, "0.6.0")) {
         .julia$init_ <- .julia$compile(
             sig = c(dir = "character"),
             body = "jl_init(CHAR(STRING_ELT(dir, 0))); return R_NilValue;"
         )
 
         .julia$init <- function() .julia$init_(.julia$bin_dir)
     }
-    if (.julia$VERSION >= "0.6.0") {
+    if (newer(.julia$VERSION, "0.6.0")) {
         .julia$init <- .julia$compile(
             sig = c(),
             body = "jl_init(); return R_NilValue;"