Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arch #225

Closed
wants to merge 5 commits into from
Closed

Fix arch #225

wants to merge 5 commits into from

Conversation

tseaward
Copy link

@tseaward tseaward commented Apr 10, 2024

Description

JuliaCall cannot find the correct version of Julia on M-series Mac.

  1. The command Sys.info()["machine"] returns aarch64 on my M2 MacBook Air. This is not catered for in julia_url();
  2. julia_latest_version() returns the incorrect value since v1.10 as it uses string sorting to find the maximum version; and
  3. short_version in julia_url() is set incorrectly since v1.10 since it only subsets the first 3 characters.

Related Issue

Example

tseaward and others added 3 commits April 10, 2024 20:56
The command `Sys.info()["machine"]` returns `aarch64` on my machine. 

This case is not handled by the current `if` statements.

This change corrects this.
@tseaward
Copy link
Author

@Non-Contradiction

@ViralBShah
Copy link
Contributor

@JackDunnNZ Any idea why CI only runs on master and not on the PRs?

@ViralBShah ViralBShah closed this Nov 7, 2024
@ViralBShah ViralBShah reopened this Nov 7, 2024
@ViralBShah
Copy link
Contributor

Do we still need this, since the CI seems to be running fine.

@tseaward
Copy link
Author

tseaward commented Nov 7, 2024

Hi @ViralBShah, thanks for taking the time to look at this. No, using R4.4.2 Sys.info()["machine"] is returning arm64, so all good. Thanks again.

@tseaward tseaward closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants