Support for argument names, keyword arguments and argument default values #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barche
reviewed
Jan 12, 2024
|
Can you please try the above fix for MSVC and also rebase on libcxxwrap main? |
melven
force-pushed
the
func_arg_support
branch
from
ce67e08
to
be8d13b
Compare
melven
force-pushed
the
func_arg_support
branch
from
f629b91
to
41712d9
Compare
|
Remaining problem with MSVC looks like the issue discussed here: https://developercommunity.visualstudio.com/t/error-C2187-syntax-error:-attribute-sp/10439022 So I replaced a lambda by a template function which seems to work around this... |
|
Thanks, not so easy to keep all the compilers (and especially MSVC) happy with this kind of code :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding library functionality for JuliaInterop/CxxWrap.jl#399