Skip to content

Commit

Permalink
Drop compat code for fetch(::Task) from #549
Browse files Browse the repository at this point in the history
  • Loading branch information
martinholters committed Oct 8, 2019
1 parent d77d3b0 commit e154827
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 13 deletions.
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,6 @@ Currently, the `@compat` macro supports the following syntaxes:

* Single-argument `permutedims(x)` for matrices and vectors ([#24839]).

* `fetch` for `Task`s ([#25940]).

* `isbits(t::Type)` is now `isbitstype(t)` ([#26850]).

* `something` to get the first argument different from `nothing`, unwrapping those
Expand Down
4 changes: 0 additions & 4 deletions src/Compat.jl
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,6 @@ end
end
end

@static if VERSION < v"0.7.0-DEV.3936"
Base.fetch(t::Task) = wait(t)
end

# https://github.com/JuliaLang/julia/pull/27077
@static if VERSION < v"0.7.0-DEV.5087"
export isletter
Expand Down
7 changes: 7 additions & 0 deletions test/old.jl
Original file line number Diff line number Diff line change
Expand Up @@ -1066,3 +1066,10 @@ end
1 2 1 2 1 2
3 4 3 4 3 4]
@test repeat([1, 2], 1, 2, 3) == [x for x in 1:2, y in 1:2, z in 1:3]

# 0.7.0-DEV.3936
@test let ct = current_task(), t = @task true
schedule(ct)
yieldto(t)
fetch(t)
end
7 changes: 0 additions & 7 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -87,13 +87,6 @@ end
@test length(Compat.CartesianIndices((1:2,))) == 2
@test length(Compat.CartesianIndices((1:2, -1:1))) == 6

# 0.7.0-DEV.3936
@test let ct = current_task(), t = @task true
schedule(ct)
yieldto(t)
fetch(t)
end

# 0.7.0-DEV.5087
@test isletter('a')
@test isletter('β')
Expand Down

0 comments on commit e154827

Please sign in to comment.