Add @__DIR__ macro. #281
Add @__DIR__ macro. #281
Conversation
| @@ -1463,4 +1463,9 @@ if VERSION < v"0.6.0-dev.374" | |||
| end | |||
| end | |||
|
|
|||
| if VERSION < v"0.6.0-dev.404" | |||
There was a problem hiding this comment.
did you run the commit-name script at the merge commit?
There was a problem hiding this comment.
This should probably be !isdefined(Base, Symbol("@__DIR__")) for clarity
There was a problem hiding this comment.
@tkelman yes. Since CI says that it was wrong, how do I do it correctly? Or should I use @TotalVerb's suggestion?
There was a problem hiding this comment.
isdefined sounds fine to me. Suggests there may be a bug in that script though...
There was a problem hiding this comment.
hm, I get
$ git checkout -q 11ff9abd013e8c8f745616057c1076e6c6b761c5 && contrib/commit-name.sh
0.6.0-dev.528
at the merge commit JuliaLang/julia@11ff9ab
There was a problem hiding this comment.
Obviously I did not run it at the merge commit. Sorry, my bad!
There was a problem hiding this comment.
#281 (comment) is still better
|
With the correct version CI passes 👍 |
* Add @__DIR__ macro. * Correct version number.
* Remove `take!(::Task)` definition for Julia versions prior to 0.6 Was added in #307. * Remove `redirect_std*(f, stream)` definitions for Julia prior to v0.6 Were added in #275. * Remove at-__DIR__ macro definition for Julia versions prior to 0.6 Was added in #281. * Remove `broadcast` definition for equal-length tuples Was added in #324 and #328 * Remove definitions of `unsafe_get` and `isnull` fallsback Were added in #287. * Remove defintions of `xor` and `⊻` Were added in #289. * Definitions of `numerator` and `denominator` Were added in #290. * Remove defintion of `iszero` Was added in #305. * Remove definition of `>:` Was added in #336 * Remove definition of `take!(::Base.AbstractIOBuffer)` Was added in #290. * Remove definiton of `.&` and `.|` Were added in #306. * Remove definition of `Compat.isapprox` Was added in #309.
Another nightly PR but this time with a branch and all...