Support new syntax for type alias with free parameters #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TotalVerb
reviewed
Feb 12, 2017
| @@ -1815,7 +1817,7 @@ end | |||
| if VERSION < v"0.5.0-dev+3669" | |||
| using Base: promote_op | |||
| import Base: * | |||
| typealias SubMatrix{T} SubArray{T,2} | |||
| eval(Expr(:typealias, :(SubMatrix{T}), :(SubArray{T,2}))) | |||
There was a problem hiding this comment.
Why doesn't @compat SubMatrix{T} = SubArray{T,2} work here?
There was a problem hiding this comment.
Just avoiding using @compat in this file in general.
There was a problem hiding this comment.
@compat is used 20 or so times in this file. Is there a reason to avoid it?
There was a problem hiding this comment.
I just don't ever want to worry about ordering unless it's very hard to do without @compat.
yuyichao
force-pushed
the
yyc/typealias
branch
from
278feef to
7442bbd
Compare
|
Added support for |
|
before anyone tags a new version here, should be sure to resolve #324 (comment) in the readme |
Merged
yuyichao
force-pushed
the
yyc/typealias
branch
from
7442bbd to
3866f8b
Compare
martinholters
added a commit
that referenced
this pull request
Aug 27, 2018
Was added in #326, now obsolete as no longer required on minimum supported Julia version 0.6.
martinholters
added a commit
that referenced
this pull request
Aug 31, 2018
* Remove at-compat for type aliases Was added in #326, now obsolete as no longer required on minimum supported Julia version 0.6. * Remove at-compat for Nullable construction Was added in #287, now obsolete as no longer required on minimum supported Julia version 0.6. * Remove at-compat for Foo{<:Bar} sugar Was added in #317 (and #336), now obsolete as no longer required on minimum supported Julia version 0.6. * Remove at-compat for index styles Was added in #329, now obsolete as no longer required on minimum supported Julia version 0.6. * Remove at-compat for type declarations Was added in #325, now obsolete as no longer required on minimum supported Julia version 0.6. * Remove unused at-compat helper functions * Remove README entries for removed at-compat functionality * new style call overloading (added in #181, removed in #385) * `get(io, s false)` (added in #212, #215, #225, removed in #385) * `.=` (added in #292 and #316, removed in #372) * Remove `Compat.collect(A)` Was added in #350 and #351, now obsolete as no longer required on minimum supported Julia version 0.6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.