Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Project.toml with updated Pkg uuid and bump version to 0.66.0 #561

Merged
merged 2 commits into from
May 31, 2018

Conversation

martinholters
Copy link
Member

Note: As this bumps the version, the merge commit should also be tagged as a release. I don't see why we shouldn't do so, soon, just want to be clear about it.

@martinholters martinholters requested a review from KristofferC May 30, 2018 13:36
@martinholters
Copy link
Member Author

ERROR: Pkg.Types.CommandError("Cannot add package with the same name or uuid as the project")

Travis just continues, but AV fails. I guess the build_script needs some adjustment...

@martinholters
Copy link
Member Author

... or could we make Pkg.clone more tolerant here, given that its raison d'être is to ease transition?

@KristofferC
Copy link
Member

Ref travis-ci/travis-build#1392. Could also make Pkg.clone do nothing if it tries to clone the current project.

@martinholters
Copy link
Member Author

Yes, fixing the Travis script is a good idea, of course; too bad we cannot centralize that for AppVeyor. But eventually, people will have to adjust the AV scripts, so forcing them to do so when adding a Project.toml might be ok.

@martinholters
Copy link
Member Author

CI back to all-green 🎉

My plan would be to merge #560 first, then this on top to have a reasonably "deprecation clean" release.

Note: This should be squashed upon merge.

@martinholters martinholters merged commit 1feafe9 into master May 31, 2018
@martinholters martinholters deleted the mh/project branch May 31, 2018 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants