Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added eachrow/col/slice for v1.0 #658

Merged
merged 8 commits into from
Aug 22, 2019

Conversation

jiegillet
Copy link
Contributor

@jiegillet jiegillet commented Jul 24, 2019

Let's get the ball going for #639.

This won't work at all for 0.6 from what I saw on JuliaBox, too many things missing (axes, OneTo...). 0.6 support is getting dropped though, right?

Also, I don't know how to get the exact version where these were defined. It was this PR JuliaLang/julia#29749

Copy link
Member

@martinholters martinholters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I support dropping support for 0.6, we still do support it and run CI on it, so we should also keep the tests passing.

README.md Outdated Show resolved Hide resolved
src/Compat.jl Outdated Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
src/Compat.jl Outdated Show resolved Hide resolved
src/Compat.jl Outdated Show resolved Hide resolved
Copy link
Member

@martinholters martinholters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little issue with the test version bound and a suggestion regarding the README entry, otherwise LGTM.

README.md Outdated Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
jiegillet and others added 2 commits August 21, 2019 21:35
Co-Authored-By: Martin Holters <martin.holters@hsu-hh.de>
Co-Authored-By: Martin Holters <martin.holters@hsu-hh.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants