Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add zero arg ReverseOrdering constructor #679

Merged
merged 5 commits into from
Nov 18, 2019

Conversation

oxinabox
Copy link
Contributor

Project.toml Show resolved Hide resolved
Copy link
Member

@martinholters martinholters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the version

@martinholters
Copy link
Member

On second thought, also needs a README entry.

README.md Outdated Show resolved Hide resolved
oxinabox and others added 3 commits November 18, 2019 09:05
Co-Authored-By: Martin Holters <martin.holters@hsu-hh.de>
@martinholters martinholters merged commit 88b9fc0 into JuliaLang:master Nov 18, 2019
@oxinabox
Copy link
Contributor Author

can we tag a release please

@martinholters
Copy link
Member

Long done: JuliaRegistries/General#5534 and https://github.com/JuliaLang/Compat.jl/releases/tag/v3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants