Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sincospi(x) #727

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Add sincospi(x) #727

merged 1 commit into from
Oct 27, 2020

Conversation

jmert
Copy link
Contributor

@jmert jmert commented Oct 22, 2020

Added to Base in JuliaLang/julia#35816

The five tests I added cover the methods I see on Julia v1.6 master:

julia> methods(sincospi)
# 5 methods for generic function "sincospi":
[1] sincospi(x::T) where T<:AbstractFloat in Base.Math at special/trig.jl:871
[2] sincospi(x::T) where T<:Rational in Base.Math at special/trig.jl:903
[3] sincospi(x::Integer) in Base.Math at special/trig.jl:935
[4] sincospi(x::Real) in Base.Math at special/trig.jl:938
[5] sincospi(z::Complex{T}) where T in Base.Math at special/trig.jl:1009

@simeonschaub
Copy link
Member

👍 Looks good to me!

Copy link
Member

@martinholters martinholters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to also bump the version in Project.toml and we'll tag immediately after merging.

@jmert
Copy link
Contributor Author

jmert commented Oct 26, 2020

Feel free to also bump the version in Project.toml and we'll tag immediately after merging.

Done.

@martinholters martinholters merged commit aca5c27 into JuliaLang:master Oct 27, 2020
@martinholters
Copy link
Member

Thanks for the contribution! .. and welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants