Add splat
#786
Add splat
#786
Conversation
| if v"1.10.0-" <= VERSION < v"1.10.0-DEV.360" || | ||
| v"1.9.0-DEV.513" <= VERSION < v"1.9.0-beta3" | ||
| # these versions of Base export Splat (which we use) but pretty-print with capital `S` | ||
| @test repr(splat(+)) == "Splat(+)" | ||
| @test repr(MIME"text/plain"(), splat(+)) == "Splat(+)" |
There was a problem hiding this comment.
This is from between JuliaLang/julia#42717 and JuliaLang/julia#48038. Note that it only affects pre-release versions, so I decided not to worry about it too much and try to print lower-case everywhere, but instead just make the tests pass.
Codecov Report
@@ Coverage Diff @@
## master #786 +/- ##
==========================================
+ Coverage 91.86% 91.92% +0.06%
==========================================
Files 2 2
Lines 258 260 +2
==========================================
+ Hits 237 239 +2
Misses 21 21
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Should probably get #787 in first, to have a CI run with 1.9 on this one. |
martinholters
force-pushed
the
mh/splat
branch
from
24e3081
to
21b2df9
Compare
|
Ok, CI looks good (including on 1.9), so good to go from my side. |
|
Our tests currently fail on Julia 1.9 and master because they test for |
Ref. #785 and JuliaLang/julia#48038.
cc @MasonProtter and @mcabbott