Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-3] Put uses of @pure and @_pure_meta behind @static if #792

Merged
merged 1 commit into from
Feb 18, 2023

Conversation

martinholters
Copy link
Member

Ref. JuliaLang/julia#48682 (comment). This makes Compat at least load again on Julia master.

@codecov
Copy link

codecov bot commented Feb 18, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-3@7463409). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             release-3     #792   +/-   ##
============================================
  Coverage             ?   81.54%           
============================================
  Files                ?        4           
  Lines                ?      791           
  Branches             ?        0           
============================================
  Hits                 ?      645           
  Misses               ?      146           
  Partials             ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@martinholters
Copy link
Member Author

Tests still fail on Julia nightly, but at least, loading works, so this should fix the immediate problems in the ecosystem.

Fixing the tests might still be worthwhile but is less urgent and therefore should happen separately.

Copy link
Member

@maleadt maleadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, confirmed that this works.

@martinholters
Copy link
Member Author

Test fix is at #794 (I hope). If that works, I'll merge that one first, then verify tests pass here as well, merge this and tag.

If any problems in #794 show up, I'll merge this as is and tag.

@martinholters martinholters merged commit 3a03b54 into release-3 Feb 18, 2023
@martinholters martinholters deleted the mh/pure-behind-static-if branch February 18, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants