Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unverified HTTPS: don't set CURLOPT_SSL_VERIFYHOST=0 #114

Merged
merged 2 commits into from
Apr 21, 2021
Merged

unverified HTTPS: don't set CURLOPT_SSL_VERIFYHOST=0 #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b774c1
tests: move ENV var save/reset out of testset
StefanKarpinski Apr 20, 2021
86e52d7
unverified HTTPS: don't set CURLOPT_SSL_VERIFYHOST=0
StefanKarpinski Apr 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/Curl/Easy.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ set_url(easy::Easy, url::AbstractString) = set_url(easy, String(url))

function set_ssl_verify(easy::Easy, verify::Bool)
setopt(easy, CURLOPT_SSL_VERIFYPEER, verify)
setopt(easy, CURLOPT_SSL_VERIFYHOST, verify*2)
end

function set_ssh_verify(easy::Easy, verify::Bool)
Expand Down
30 changes: 23 additions & 7 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,13 +403,14 @@ include("setup.jl")
end
end

save_env = get(ENV, "JULIA_SSL_NO_VERIFY_HOSTS", nothing)
delete!(ENV, "JULIA_SSL_NO_VERIFY_HOSTS")

@testset "bad TLS" begin
save_env = get(ENV, "JULIA_SSL_NO_VERIFY_HOSTS", nothing)
urls = [
"https://wrong.host.badssl.com"
"https://untrusted-root.badssl.com"
]
ENV["JULIA_SSL_NO_VERIFY_HOSTS"] = nothing
@testset "bad TLS is rejected" for url in urls
resp = request(url, throw=false)
@test resp isa RequestError
Expand Down Expand Up @@ -449,11 +450,26 @@ include("setup.jl")
@test resp isa Response
@test resp.status == 200
end
if save_env !== nothing
ENV["JULIA_SSL_NO_VERIFY_HOSTS"] = save_env
else
delete!(ENV, "JULIA_SSL_NO_VERIFY_HOSTS")
end
delete!(ENV, "JULIA_SSL_NO_VERIFY_HOSTS")
end

@testset "SNI required" begin
url = "https://juliahub.com" # anything served by CloudFront
# secure verified host request
resp = request(url, throw=false, downloader=Downloader())
@test resp isa Response
@test resp.status == 200
# insecure unverified host request
ENV["JULIA_SSL_NO_VERIFY_HOSTS"] = "**"
resp = request(url, throw=false, downloader=Downloader())
@test resp isa Response
@test resp.status == 200
end

if save_env !== nothing
ENV["JULIA_SSL_NO_VERIFY_HOSTS"] = save_env
else
delete!(ENV, "JULIA_SSL_NO_VERIFY_HOSTS")
end

@__MODULE__() == Main && @testset "ftp download" begin
Expand Down