-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sk/backports 1.4 #184
Merged
Merged
sk/backports 1.4 #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 99165c6)
(cherry picked from commit cd002c3)
(cherry picked from commit 848d374)
(cherry picked from commit 3870614)
ChainRulesCore defines `==(a, b::AbstractThunk)` and its converse, and this invalidates a couple of poorly-typed Symbol checks. This more "SSA-like" way of writing the code is easier to infer. (cherry picked from commit 25f7af3)
Since #114, we only turn off peer verification, not host verification when the `SSL_NO_VERIFY` variables are set. This means that the last set of tests in the "SSL no verify override" testset *should* fail for `wrong.host.badssl.com`. That is not what I was seeing, however — the test was still passing — which I found puzzling but just moved on with my life at the time. It turns out that the test *does* fail if libcurl is build with OpenSSL. Since whether the test passes or not for that host depends on how things are built, this change simply skips the test (by popping the URL from the set of tested URLS for that testset). The tests above that which use the easy hook mechanism are fixed in a different way: for those I made the hook disable both host and peer verification, which should fix the tests for any bad host including when the server sends the wrong host name. (cherry picked from commit e22219f)
Somewhat surprisingly, the type of this is not IOBuffer, but a related type (Base.GenericIOBuffer{Base.CodeUnits{UInt8, String}}). (cherry picked from commit 470b7f0)
(cherry picked from commit 5f1509d)
If no content length is set while uploading some contents, Curl defaults to use chunked transfer encoding. In some cases we want to prevent that because the server may not support chunked transfers. With this change, the request method will also look at the headers while determining the input size and if found call `set_upload_size` as usual. So to switch off chunked transfers, one must also know and set the content length header while invoking `download` or `request` methods. (cherry picked from commit ab628ab)
These only add one callback so having them be plural is weird. (cherry picked from commit 5bd0826)
This adds end-to-end tests for the changes introduced in #167. Verbose mode is switched off for these tests, but switching it on would show that not setting content-length headers results in chunked transfer encoding while setting it prevents that. Both tests should pass. (cherry picked from commit 911368d)
(cherry picked from commit 2101bde)
(cherry picked from commit 2a21b15)
(cherry picked from commit 3654257)
see https://curl.se/libcurl/c/sftpget.html see discussion https://discourse.julialang.org/t/how-to-use-downloads-download-with-sftp/76480 (cherry picked from commit 959a9a1)
Slightly passive aggressive, but I'm tired of people filing issues about their misconfigured Julia installs. (cherry picked from commit a7a0346)
Unclear what happened here but there's a crash which could be investigated. In the meantime I'm just adjusting the compat and testing to match reality.
StefanKarpinski
force-pushed
the
sk/backports-1.4
branch
from
March 24, 2022 20:16
c7ced35
to
6fccb97
Compare
Codecov Report
@@ Coverage Diff @@
## release-1.4 #184 +/- ##
===============================================
+ Coverage 92.95% 93.69% +0.73%
===============================================
Files 5 5
Lines 511 523 +12
===============================================
+ Hits 475 490 +15
+ Misses 36 33 -3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CURLOPT_NOBODY
automatically forHEAD
s? #131 and add test (fix #131 and add test #132)IOBuffer(codeunits(str))
#143)badssl.julialang.org
implementation (Use our own custombadssl.julialang.org
implementation #178)