Support begin/end indexing of SourceFile
#201
Conversation
| @test SourceFile("a\nb\n")[3:end] == "b\n" | ||
| if Base.VERSION >= v"1.4" | ||
| # Protect the `[begin` from being viewed by the parse on older Julia versions | ||
| @test eval(Meta.parse("""SourceFile("a\nb\n")[begin:end]""")) == "a\nb\n" |
There was a problem hiding this comment.
hehehe we are the parser!
So we can almost use JuliaSyntax.parse(Expr, """SourceFile("a\nb\n")[begin:end]""", version=v"1.6") unconditionally here.
But alas, lowering won't understand the result with the begin embedded in the Expr... so not really 😅
There was a problem hiding this comment.
It is indeed quite ironic! I guess if this were to swap itself in as the include parser, then even older Julia versions would be prepared for this. But given the necessary changes in JuliaLang/julia#46372, presumably this won't happen.
There was a problem hiding this comment.
JuliaSyntax.enable_in_core!() does make it work with include()!
But only in Julia 1.6+ because it requires the hooks implemented in JuliaLang/julia#35243
No description provided.