Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

Register new package Bridge.jl v0.4.1 #10316

Merged
merged 1 commit into from
Jul 24, 2017

Conversation

attobot
Copy link
Contributor

@attobot attobot commented Jul 18, 2017

Repository: mschauer/Bridge.jl
Release: v0.4.1
cc: @mschauer

Please make sure that:

  • CI passes for supported Julia versions (if applicable).
  • Version bounds reflect minimum requirements.

@mschauer This PR will remain open for 24 hours for feedback (which is optional). If you get feedback, please let us know if you are making changes, and we'll merge once you're done.

@mschauer
Copy link
Contributor

Replaces #10005. Thank you to @tkelman for helpful comments.

@attobot
Copy link
Contributor Author

attobot commented Jul 18, 2017

Repository: mschauer/Bridge.jl
Release: v0.4.1
Travis: Travis Build Status
cc: @mschauer

Please make sure that:

  • CI passes for supported Julia versions (if applicable).
  • Version bounds reflect minimum requirements.

@mschauer This PR will remain open for 24 hours for feedback (which is optional). If you get feedback, please let us know if you are making changes, and we'll merge once you're done.

@mschauer
Copy link
Contributor

Julia 0.7 build failure is due to JuliaStats/Distributions.jl#644

@mschauer
Copy link
Contributor

I am making some changes

@attobot
Copy link
Contributor Author

attobot commented Jul 19, 2017

Repository: mschauer/Bridge.jl
Release: v0.4.1
cc: @mschauer

Please make sure that:

  • CI passes for supported Julia versions (if applicable).
  • Version bounds reflect minimum requirements.

@mschauer This PR will remain open for 24 hours for feedback (which is optional). If you get feedback, please let us know if you are making changes, and we'll merge once you're done.

Distributions
StaticArrays
Polynomials
Compat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's best to declare a minimum version dependency that implements the features you need.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but this is possibly the next release of Compat, the next release of StaticArrays and the next release of Distributions ;-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, it looks like the package isn't passing tests until you get those packages to tag?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it passed test locally on my machine with all the PR branches checked out

Copy link
Contributor

@mschauer mschauer Jul 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Distributions v0.14.2
  • StaticArrays v0.6.1
  • Compat v0.28.0

@mschauer
Copy link
Contributor

Waiting for Compat.jl getting tagged.

@attobot
Copy link
Contributor Author

attobot commented Jul 24, 2017

Repository: mschauer/Bridge.jl
Release: v0.4.1
Travis: Travis Build Status
cc: @mschauer

Please make sure that:

  • CI passes for supported Julia versions (if applicable).
  • Version bounds reflect minimum requirements.

@mschauer This PR will remain open for 24 hours for feedback (which is optional). If you get feedback, please let us know if you are making changes, and we'll merge once you're done.

@mschauer
Copy link
Contributor

All checks have passed.

@attobot
Copy link
Contributor Author

attobot commented Jul 24, 2017

Repository: mschauer/Bridge.jl
Release: v0.4.1
Travis: Travis Build Status
cc: @mschauer

Please make sure that:

  • CI passes for supported Julia versions (if applicable).
  • Version bounds reflect minimum requirements.

@mschauer This PR will remain open for 24 hours for feedback (which is optional). If you get feedback, please let us know if you are making changes, and we'll merge once you're done.

@tkelman tkelman merged commit 4e4180e into JuliaLang:metadata-v2 Jul 24, 2017
@attobot attobot deleted the Bridge/v0.4.1 branch July 24, 2017 03:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants