These tests didn't do what you thought they did #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `rng` assignment inside the closure was actually reassigning the local `rng`, which would then occaisionally segfault, because `RandomDevice` is immutable, so there's nothing that actually rooted it to the device object. Side note: Somebody should probably add assertions that the various things we're trying to protect by rooting them in the context object are actually mutable. However, I've spent too much time on this already so I'll leave that to somebody else ;).
quinnj
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rngassignment inside the closure was actually reassigning the localrng,which would then occaisionally segfault, because
RandomDeviceis immutable,so there's nothing that actually rooted it to the device object.
Side note: Somebody should probably add assertions that the various things
we're trying to protect by rooting them in the context object are actually mutable.
However, I've spent too much time on this already so I'll leave that to somebody else ;).