-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove use of jl_set_value on 1.9. fix UndefVarError for new nightly error formatting #709
Conversation
Codecov Report
@@ Coverage Diff @@
## master #709 +/- ##
=======================================
Coverage 93.42% 93.42%
=======================================
Files 2 2
Lines 517 517
=======================================
Hits 483 483
Misses 34 34 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
It might be better to call jl_f_setglobal, but this does look the same |
Error appears to now be
|
This might be due to JuliaLang/julia#45838? @aviatesk Any suggestions on what we might be able to do here? |
4c747b4
to
81eec64
Compare
bump @aviatesk |
Should be fixed via JuliaLang/julia#46866 |
1.6 failures are #706 |
This line is failing on Windows x86 1.7: PackageCompiler.jl/test/runtests.jl Line 76 in 5b3b07c
|
pushed fix for test breakage due to JuliaLang/julia#47077 |
RTM? The macos 1.8 runner is hanging on master too (#730) |
I'm going to merge given the discussion above and that tests pass on nightly now |
Fixes #708 (I hope).
@vtjnash is this the correct usage?