Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use smaller micromamba_jll rather than huge MKL_jll to test lazy artifacts #772

Merged
merged 1 commit into from
Jan 28, 2023

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Jan 27, 2023

Fixes #766

MKL_jll was used to test lazy artifact downloading.

micromamba_jll artifacts are also lazy but a lot smaller (~5-7 MiB) than MKL_jll which is nearly 1GB

This switches over.

https://github.com/JuliaBinaryWrappers/micromamba_jll.jl/blob/main/Artifacts.toml

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Merging #772 (027fb6b) into master (027fb6b) will not change coverage.
The diff coverage is n/a.

❗ Current head 027fb6b differs from pull request most recent head bcbbe65. Consider uploading reports for the commit bcbbe65 to get more accurate results

@@           Coverage Diff           @@
##           master     #772   +/-   ##
=======================================
  Coverage   83.08%   83.08%           
=======================================
  Files           3        3           
  Lines         662      662           
=======================================
  Hits          550      550           
  Misses        112      112           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@DilumAluthge
Copy link
Member

micromamba_jll artifacts are lazy but a lot smaller (~5-7 MiB) than MKL_jll which is nearly 1GB

To provide context for others (like me) that might be confused by this sentence, the MKL_jll artifacts are lazy (https://github.com/JuliaBinaryWrappers/MKL_jll.jl/blob/main/Artifacts.toml).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid redownloading MKL_jll for each testset
2 participants