Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify that project arg should be a path. #773

Merged
merged 3 commits into from
Jan 29, 2023

Conversation

sjkelly
Copy link
Collaborator

@sjkelly sjkelly commented Jan 27, 2023

This otherwise yields a confusing error message such as:

ERROR: LoadError: could not find project at "/home/user/julia_directory/Project.toml"

When this is clearly pointing to a valid julia Project.toml. We will now error and clarify that the path should be specified, not file.

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Merging #773 (6ac0a35) into master (25cd2e4) will decrease coverage by 0.10%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #773      +/-   ##
==========================================
- Coverage   83.10%   83.00%   -0.10%     
==========================================
  Files           3        3              
  Lines         663      665       +2     
==========================================
+ Hits          551      552       +1     
- Misses        112      113       +1     
Impacted Files Coverage Δ
src/PackageCompiler.jl 93.11% <50.00%> (-0.17%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

This otherwise yields a confusing error message such as:

```
ERROR: LoadError: could not find project at "/home/user/julia_directory/Project.toml"
```

When this is clearly pointing to a valid julia Project.toml.
We will now error and clarify that the path should be specified, not file.
src/PackageCompiler.jl Outdated Show resolved Hide resolved
src/PackageCompiler.jl Outdated Show resolved Hide resolved
sjkelly and others added 2 commits January 28, 2023 12:21
Co-authored-by: Ian Butterworth <i.r.butterworth@gmail.com>
Co-authored-by: Ian Butterworth <i.r.butterworth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants