only bundle libraries that are needed #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
force-pushed
the
kc/only_bundle_used_libraries
branch
from
7cb3247 to
6f7a883
Compare
KristofferC
force-pushed
the
kc/only_bundle_used_libraries
branch
from
6f7a883 to
94501fc
Compare
Codecov Report
@@ Coverage Diff @@
## master #823 +/- ##
==========================================
+ Coverage 82.59% 84.03% +1.43%
==========================================
Files 3 3
Lines 655 714 +59
==========================================
+ Hits 541 600 +59
Misses 114 114
|
KristofferC
force-pushed
the
kc/only_bundle_used_libraries
branch
2 times, most recently
from
f1243f7 to
1fedc58
Compare
KristofferC
force-pushed
the
kc/only_bundle_used_libraries
branch
from
1fedc58 to
863d970
Compare
KristofferC
changed the title
|
I think this should be ready to go. |
|
Out of curiosity, what will this PR being to PC.jl? From the title I assume it will improve somehow which libraries are bundled with a sysimage, but I can't tell from looking at the code 😬 |
|
It will:
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.