Skip to content

Commit

Permalink
PlatformEngines: revert API part of headers support (broken)
Browse files Browse the repository at this point in the history
This was broken anyway since only `download` actually used the
headers argument; I forgot to pass it through in all the other
functions. Testing fail.
  • Loading branch information
StefanKarpinski committed Dec 11, 2019
1 parent 6825b48 commit 6dd7f34
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions src/PlatformEngines.jl
Original file line number Diff line number Diff line change
Expand Up @@ -592,7 +592,6 @@ end
download(
url::AbstractString,
dest::AbstractString;
headers::Vector{Pair{String}} = Pair{String}[],
verbose::Bool = false,
)
Expand All @@ -602,11 +601,9 @@ already exists and the server and download engine support it.
function download(
url::AbstractString,
dest::AbstractString;
headers::Vector{Pair{String}} = Pair{String}[],
verbose::Bool = false,
)
hdrs = String["$key: $val" for (key, val) in headers]
download_cmd = gen_download_cmd(url, dest, hdrs...)
download_cmd = gen_download_cmd(url, dest)
if verbose
@info("Downloading $(url) to $(dest)...")
end
Expand All @@ -625,7 +622,6 @@ end
url::AbstractString,
hash::Union{AbstractString, Nothing},
dest::AbstractString;
headers::Vector{Pair{String}} = Pair{String}[],
verbose::Bool = false,
force::Bool = false,
quiet_download::Bool = true,
Expand All @@ -652,7 +648,6 @@ function download_verify(
url::AbstractString,
hash::Union{AbstractString, Nothing},
dest::AbstractString;
headers::Vector{Pair{String}} = Pair{String}[],
verbose::Bool = false,
force::Bool = false,
quiet_download::Bool = true,
Expand Down Expand Up @@ -834,7 +829,6 @@ end
url::AbstractString,
hash::Union{AbstractString, Nothing},
dest::AbstractString;
headers::Vector{Pair{String}} = Pair{String}[],
tarball_path = nothing,
ignore_existence::Bool = false,
force::Bool = false,
Expand Down Expand Up @@ -868,7 +862,6 @@ function download_verify_unpack(
url::AbstractString,
hash::Union{AbstractString, Nothing},
dest::AbstractString;
headers::Vector{Pair{String}} = Pair{String}[],
tarball_path = nothing,
ignore_existence::Bool = false,
force::Bool = false,
Expand Down

0 comments on commit 6dd7f34

Please sign in to comment.