Merge #1080

1080: Overload Base.showerror instead of Base.show for PkgError. r=fredrikekre a=fredrikekre Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
JuliaLang · Feb 20, 2019 · f3c1ce1 · f3c1ce1
2 parents 616bd61 + cae8b4f
commit f3c1ce1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/Types.jl b/src/Types.jl
@@ -110,7 +110,7 @@ struct PkgError <: Exception
     msg::String
 end
 pkgerror(msg::String...) = throw(PkgError(join(msg)))
-Base.show(io::IO, err::PkgError) = print(io, err.msg)
+Base.showerror(io::IO, err::PkgError) = print(io, err.msg)
 
 
 ###############

diff --git a/test/pkg.jl b/test/pkg.jl
@@ -683,6 +683,12 @@ end
     end
 end
 
+@testset "PkgError printing" begin
+    err = PkgError("foobar")
+    @test occursin("PkgError(\"foobar\")", sprint(show, err))
+    @test sprint(showerror, err) == "foobar"
+end
+
 include("repl.jl")
 include("api.jl")
 include("registry.jl")