Force mv in create_artifact
#2292
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, you may have missed the subsequent comment. So, not sure this will actually help. |
|
Ah, crud, I see. You're right. This won't fix it. What if we also passed |
|
There are many, many things depending on particular behavior of the file I/O primitives; can't really change things in Base easily. We need to MPI I/O all our stuff, which will mean significant PRs to packages we use or specialized forks. Neither option is appealing. 🤷♂️ Simplest solution for now is: If mpirank == 0
...
end
MPI.Barrier(MPI.COMM_WORLD)Which is bad for performance, but should avoid distributed races. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over at ClimateMachine.jl, we're seeing race conditions when using
create_artifacton multiple processors (e.g., here). This is likely not the best fix but, based on this thread, it seems like it may work. Looping in @kpamnany. I'm hoping that this will partially fix ClimateMachine's 1678.Doing this the "right way" seems ultimately dependent on resolving cross-platform file locking. Pidfile.jl seems like a promising solution, but I'm not sure what the status is on moving this into Base.